From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: Revert "dt-bindings: display: bridge: ldb: Fill in reg property" Date: Tue, 05 May 2026 07:44:15 +1000 Message-ID: In-Reply-To: <20260504-v7-1-topic-ldb-fixes-v1-2-0125d937ff7f@pengutronix.de> References: <20260504-v7-1-topic-ldb-fixes-v1-0-0125d937ff7f@pengutronix.de> <20260504-v7-1-topic-ldb-fixes-v1-2-0125d937ff7f@pengutronix.de> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Patch Review This reverts commit `16c8d76abe83`, removing the `reg` and `reg-names` prop= erty definitions themselves from the binding schema, and updating the examp= le to match. **Changes reviewed:** Property definitions removed: ```yaml - reg: - maxItems: 2 - - reg-names: - items: - - const: ldb - - const: lvds ``` Example updated =E2=80=94 removes `#address-cells`, `#size-cells` from the = parent `blk-ctrl` node, and `reg`/`reg-names` from the bridge child: ```yaml - #address-cells =3D <1>; - #size-cells =3D <1>; - - bridge@5c { + bridge { compatible =3D "fsl,imx8mp-ldb"; - reg =3D <0x5c 0x4>, <0x128 0x4>; - reg-names =3D "ldb", "lvds"; ``` **Assessment:** Correct. The resulting binding file (verified above) is cle= an and consistent. The example no longer needs `#address-cells`/`#size-cell= s` in the parent since no child has a `reg` property with a unit address. T= he binding still has `additionalProperties: false`, which will correctly re= ject any DTS that still tries to pass `reg` =E2=80=94 this is fine since pa= tches 3 and 4 clean up the actual DTS files. **One observation:** Since `additionalProperties: false` is set, after this= patch but before patches 3-4, running `dt_binding_check` against the exist= ing imx8mp/imx6sx DTS files would produce schema validation warnings (the D= TS files still have `reg` properties that the schema now disallows). This i= s a transient bisection issue =E2=80=94 not a problem in practice since the= series is applied atomically, but worth noting. Some maintainers prefer DT= S changes before binding changes to avoid this. The current ordering (bindi= ng first, DTS second) is also commonly accepted. **No blocking issues.** --- --- Generated by Claude Code Patch Reviewer