From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm: bridge: dw_hdmi: Only notify connected status on HPD interrupt Date: Tue, 05 May 2026 07:58:54 +1000 Message-ID: In-Reply-To: <20260504191059.275928-3-jonas@kwiboo.se> References: <20260504191059.275928-1-jonas@kwiboo.se> <20260504191059.275928-3-jonas@kwiboo.se> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Patch Review Good fix. The additional `intr_stat & HDMI_IH_PHY_STAT0_HPD` check ensures a connected status is only reported on an actual HPD interrupt (not on an RX sense change while HPD is still high). This prevents the spurious "connected" event that was immediately followed by "disconnected" during cable unplug. ```c + if ((intr_stat & HDMI_IH_PHY_STAT0_HPD) && + (phy_stat & HDMI_PHY_HPD)) status = connector_status_connected; ``` Correct and well-explained. Has Reviewed-by. --- Generated by Claude Code Patch Reviewer