From mboxrd@z Thu Jan  1 00:00:00 1970
From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm/nouveau: tegra: Explicitly specify PMC instance to use
Date: Thu, 07 May 2026 13:29:34 +1000
Message-ID: <review-patch2-20260506-pmc-v1-2-a6de5da7216b@nvidia.com>
In-Reply-To: <20260506-pmc-v1-2-a6de5da7216b@nvidia.com>
References: <20260506-pmc-v1-0-a6de5da7216b@nvidia.com> <20260506-pmc-v1-2-a6de5da7216b@nvidia.com>
X-Mailer: Claude Code Patch Reviewer
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0

Patch Review

Adds `struct tegra_pmc *pmc` to `nvkm_device_tegra` and calls `devm_tegra_pmc_get()` in `nvkm_device_tegra_new()`. The error path uses `goto free`, which is correct for where the lookup is inserted (after clk_pwr, before dma_set_mask).

Minor observation: unlike other patches that use `dev_err_probe()`, this one silently returns the error code on PMC lookup failure:

```c
	tdev->pmc = devm_tegra_pmc_get(&pdev->dev);
	if (IS_ERR(tdev->pmc)) {
		ret = PTR_ERR(tdev->pmc);
		goto free;
	}
```

This is inconsistent with the other patches but matches the existing error style in this function (e.g., `clk_pwr` above it). Acceptable, but a `dev_err_probe()` would be more helpful for debugging `-EPROBE_DEFER`.

---
Generated by Claude Code Patch Reviewer