From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: media: iris: don't specify min_acc_length in the source code Date: Thu, 07 May 2026 12:40:17 +1000 Message-ID: In-Reply-To: <20260507-iris-ubwc-v5-2-e9a3aee53c49@oss.qualcomm.com> References: <20260507-iris-ubwc-v5-0-e9a3aee53c49@oss.qualcomm.com> <20260507-iris-ubwc-v5-2-e9a3aee53c49@oss.qualcomm.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Patch Review Replaces `core->iris_platform_data->ubwc_config->mal_length` (which was hardcoded to `32` for SM8550) with: ```c payload = qcom_ubwc_min_acc_length_64b(ubwc) ? 64 : 32; ``` The helper `qcom_ubwc_min_acc_length_64b()` returns true only when `ubwc_enc_version == UBWC_1_0` and `ubwc_dec_version` is `UBWC_2_0` or `UBWC_3_0`. SM8550 uses UBWC 4.x, so this returns false, yielding 32 -- matching the original hardcoded value. The upstream header does note this is "the best guess, based on the MDSS driver," but that's the API's responsibility, not this patch's concern. No issues. --- Generated by Claude Code Patch Reviewer