From mboxrd@z Thu Jan  1 00:00:00 1970
From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm: bridge: dw_hdmi: Only notify connected status on HPD interrupt
Date: Sat, 16 May 2026 16:21:41 +1000
Message-ID: <review-patch2-20260510124111.1226584-3-jonas@kwiboo.se>
In-Reply-To: <20260510124111.1226584-3-jonas@kwiboo.se>
References: <20260510124111.1226584-1-jonas@kwiboo.se> <20260510124111.1226584-3-jonas@kwiboo.se>
X-Mailer: Claude Code Patch Reviewer
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0

Patch Review

Fixes a race where an RX sense change (which happens briefly before HPD goes low during unplug) could trigger a spurious "connected" event:

```c
-		if (phy_stat & HDMI_PHY_HPD)
+		if ((intr_stat & HDMI_IH_PHY_STAT0_HPD) &&
+		    (phy_stat & HDMI_PHY_HPD))
 			status = connector_status_connected;
```

Now, a connected event is only signaled when both conditions are met: the interrupt source is HPD *and* HPD is currently high. The disconnect path (both HPD and RX_SENSE low) remains unchanged. The logic correctly addresses the described sequence of RX-low-then-HPD-low during unplug. Clean fix.

---
Generated by Claude Code Patch Reviewer