From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/exynos: fbdev: Inline exynos_drm_fbdev_update() Date: Sat, 16 May 2026 15:38:04 +1000 Message-ID: In-Reply-To: <20260511115538.57884-3-tzimmermann@suse.de> References: <20260511115538.57884-1-tzimmermann@suse.de> <20260511115538.57884-3-tzimmermann@suse.de> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Patch Review **Status: Good** `exynos_drm_fbdev_update()` was a single-caller function that always return= ed 0. Inlining it removes the `err_destroy_framebuffer` error label, which = was dead code since the function could never fail. The inlined assignments are all non-failable: ```c + info->fbops =3D &exynos_drm_fb_ops; + drm_fb_helper_fill_info(info, helper, sizes); + info->flags |=3D FBINFO_VIRTFB; + info->screen_buffer =3D exynos_gem->kvaddr; + info->screen_size =3D size; + info->fix.smem_len =3D size; ``` Removing the dead `err_destroy_framebuffer` path is correct =E2=80=94 if so= mething failed here (it can't), the fbdev teardown via `fb_destroy` would c= lean up the framebuffer anyway. No concerns. --- --- Generated by Claude Code Patch Reviewer