From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: media: renesas: vsp1: Split vsp1_du_setup_lif() Date: Sat, 16 May 2026 14:29:48 +1000 Message-ID: In-Reply-To: <20260511235637.3468558-3-laurent.pinchart+renesas@ideasonboard.com> References: <20260511235637.3468558-1-laurent.pinchart+renesas@ideasonboard.com> <20260511235637.3468558-3-laurent.pinchart+renesas@ideasonboard.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Patch Review Splits the dual-purpose `vsp1_du_setup_lif()` (enable when cfg !=3D NULL, d= isable when cfg =3D=3D NULL) into two explicit functions: `vsp1_du_enable()= ` and `vsp1_du_disable()`. A temporary inline compatibility wrapper `vsp1_d= u_setup_lif()` is added to `include/media/vsp1.h` for existing DRM callers. The split is clean =E2=80=94 the enable path keeps the existing code minus = the `if (!cfg)` block, and the disable path is the extracted block. The wra= pper correctly dispatches: ```c static inline int vsp1_du_setup_lif(struct device *dev, unsigned int pipe_i= ndex, const struct vsp1_du_lif_config *cfg) { if (cfg) return vsp1_du_enable(dev, pipe_index, cfg); else return vsp1_du_disable(dev, pipe_index); } ``` **Minor nit:** The commit message has a typo =E2=80=94 "disaple" should be = "disable": > a vsp1_du_disable() function to disaple it. Otherwise correct. --- Generated by Claude Code Patch Reviewer