From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: dt-bindings: display/msm: gpu: Document Adreno 840 Date: Sat, 16 May 2026 14:35:13 +1000 Message-ID: In-Reply-To: <20260512-kaana-gpu-dt-v1-2-13e1c07c2050@oss.qualcomm.com> References: <20260512-kaana-gpu-dt-v1-0-13e1c07c2050@oss.qualcomm.com> <20260512-kaana-gpu-dt-v1-2-13e1c07c2050@oss.qualcomm.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Patch Review **Status: Looks good** Two changes: 1. Converts the reg-layout conditional from `const` to `enum` to include both `qcom,adreno-44050a01` (Adreno 840) and `qcom,adreno-44070001`: ```diff - const: qcom,adreno-44070001 + enum: + - qcom,adreno-44050a01 + - qcom,adreno-44070001 ``` 2. Adds `qcom,adreno-44050a01` to the "clocks: false" enum list (since clocks are defined in the GMU node for A6xx+): ```diff - qcom,adreno-43051401 + - qcom,adreno-44050a01 - qcom,adreno-44070001 ``` Both changes are correct. The new compatible string is placed in sorted order in both locations. The Adreno 840 shares the same reg layout as 44070001 and follows the same GMU-based clock pattern as other modern Adreno GPUs. --- --- Generated by Claude Code Patch Reviewer