From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: driver core: platform: make the swnode check stricter Date: Sat, 16 May 2026 13:28:30 +1000 Message-ID: In-Reply-To: <20260512-swnode-remove-on-dev-unreg-v5-2-0035eff63812@oss.qualcomm.com> References: <20260512-swnode-remove-on-dev-unreg-v5-0-0035eff63812@oss.qualcomm.com> <20260512-swnode-remove-on-dev-unreg-v5-2-0035eff63812@oss.qualcomm.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Patch Review This extends the existing guard in `platform_device_register_full()` to cover all three possible double-swnode scenarios: ```c if ((pdevinfo->swnode && pdevinfo->properties) || (pdevinfo->swnode && is_software_node(pdevinfo->fwnode)) || (pdevinfo->properties && is_software_node(pdevinfo->fwnode))) return ERR_PTR(-EINVAL); ``` This looks correct and is well commented. All three combinations that could create two software nodes are properly rejected. No issues. --- Generated by Claude Code Patch Reviewer