From mboxrd@z Thu Jan  1 00:00:00 1970
From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: dt-bindings: display: renesas, rzg2l-du: Add RZ/T2H and RZ/N2H support
Date: Sat, 16 May 2026 13:13:42 +1000
Message-ID: <review-patch2-20260512144104.761531-3-prabhakar.mahadev-lad.rj@bp.renesas.com>
In-Reply-To: <20260512144104.761531-3-prabhakar.mahadev-lad.rj@bp.renesas.com>
References: <20260512144104.761531-1-prabhakar.mahadev-lad.rj@bp.renesas.com> <20260512144104.761531-3-prabhakar.mahadev-lad.rj@bp.renesas.com>
X-Mailer: Claude Code Patch Reviewer
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0

Patch Review

**Status: Has issues.**

The compatible string additions and the RZ/N2H fallback to RZ/T2H look corr=
ect:

```yaml
+          - renesas,r9a09g077-du # RZ/T2H
      - items:
+          - const: renesas,r9a09g087-du # RZ/N2H
+          - const: renesas,r9a09g077-du # RZ/T2H fallback
```

**Issue 1 =E2=80=94 `resets` removal from global `required` plus if/else pa=
ttern:**

The patch removes `resets` from the global required list:

```yaml
-  - resets
```

And then adds an if/else block to conditionally require it:

```yaml
+  - if:
+      properties:
+        compatible:
+          contains:
+            const: renesas,r9a09g077-du
+    then:
+      properties:
+        resets: false
+    else:
+      required:
+        - resets
```

The `else` clause applies to every `allOf` entry that **doesn't** match the=
 `if`. In a JSON Schema `allOf` list, each `if/then/else` item is evaluated=
 independently. Since this is its own standalone item in the `allOf` array,=
 the `else` branch should correctly require `resets` for all non-RZ/T2H com=
patibles. However, this pattern is unusual in DT bindings =E2=80=94 most sc=
hemas simply list conditional requirements via `if/then` without `else`. It=
 works, but a reviewer may ask whether it would be clearer to keep `resets`=
 in the global `required` list and only use `if/then` to mark `resets: fals=
e` for RZ/T2H, since the `else` with `required: [resets]` is redundant with=
 having it in the global list. Worth checking whether the dt-bindings maint=
ainers prefer one style or the other.

**Issue 2 =E2=80=94 port@1 constraint scope:** The patch groups `r9a09g077-=
du` (RZ/T2H) with `r9a07g043u-du` (RZ/G2UL) in the existing `if` block for =
single-port-only SoCs:

```yaml
          contains:
-            const: renesas,r9a07g043u-du
+            enum:
+              - renesas,r9a07g043u-du
+              - renesas,r9a09g077-du
```

This correctly constrains RZ/T2H to port@0 only and inherits the `port@1: f=
alse` from patch 1. This is appropriate since RZ/T2H has only a DPI output.

---
Generated by Claude Code Patch Reviewer