From mboxrd@z Thu Jan  1 00:00:00 1970
From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: phy: qualcomm: hdmi-28lpm: provide dynamic configuration
Date: Sat, 16 May 2026 11:32:10 +1000
Message-ID: <review-patch2-20260513-fd-hdmi-phy-v9-2-ca98c72f1f9f@oss.qualcomm.com>
In-Reply-To: <20260513-fd-hdmi-phy-v9-2-ca98c72f1f9f@oss.qualcomm.com>
References: <20260513-fd-hdmi-phy-v9-0-ca98c72f1f9f@oss.qualcomm.com> <20260513-fd-hdmi-phy-v9-2-ca98c72f1f9f@oss.qualcomm.com>
X-Mailer: Claude Code Patch Reviewer
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0

Patch Review

This patch replaces the fixed frequency lookup tables (the old `freqtbl[]` array with hardcoded register values for 8 specific pixel clocks) with runtime-calculated PLL configuration. This is a significant improvement as it enables arbitrary pixel clocks within the VCO range.

The PLL math looks reasonable:
```c
dc_offset = vco_freq / int_ref_freq - 1;
tmp = vco_freq % int_ref_freq;
tmp *= 0x10000;
sdm_freq_seed = div_u64(tmp, int_ref_freq);
```

**XXX comments**: There are two `XXX` comments left in the code:
```c
/* XXX: 19.2 for qcs404 */
unsigned long parent_rate = 27000000;
```
and:
```c
/* XXX: 0xc3 instead of 0x33 for qcs404 */
lf_cfg1 = dc_offset >= 30 ? 0x33 : ...
```
These are fine as markers for future QCS404 work, but should be tracked.

**Kconfig typo**: Line 5030 in the overall mbox: `"HDMI PHY presend on 32-bit platforms"` should be `"present"`. (This was actually introduced in patch 1, but worth flagging.)

---
Generated by Claude Code Patch Reviewer