From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: kunit: Add backtrace suppression self-tests Date: Sat, 16 May 2026 12:29:13 +1000 Message-ID: In-Reply-To: <20260513-kunit_add_support-v10-2-e379d206c8cd@redhat.com> References: <20260513-kunit_add_support-v10-0-e379d206c8cd@redhat.com> <20260513-kunit_add_support-v10-2-e379d206c8cd@redhat.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Patch Review **Good test coverage.** The tests exercise: - Direct WARN() suppression with count verification - Indirect WARN() from a called function (marked `noinline` =E2=80=94 good,= prevents inlining from changing the warning's call site) - Multiple warnings in one block - WARN_ON() variants (with appropriate CONFIG_DEBUG_BUGVERBOSE/CONFIG_KALLS= YMS skip conditions) - Incremental counting - Active-state transitions around suppression boundaries - Multi-scope using the direct API with sequential independent suppression = blocks - Cross-kthread isolation **The multi_scope test** validates that after `kunit_end_suppress_warning(t= est, sw1)`, the handle `sw1` still has valid count data. This works because= `kunit_release_action()` removes it from the list and frees the action ent= ry, but the `kunit_kzalloc`'d memory is still live until test teardown. Thi= s is subtle but correct =E2=80=94 worth noting that `sw1`'s memory outlives= the suppression because it's managed by `kunit_kzalloc()` (test-lifetime),= not the action. **Minor nit:** The `backtrace_suppression_test_warn_on_direct` test skips i= f `!CONFIG_DEBUG_BUGVERBOSE && !CONFIG_KALLSYMS`, while `backtrace_suppress= ion_test_warn_on_indirect` only checks `!CONFIG_DEBUG_BUGVERBOSE`. The asym= metry is because direct WARN_ON() at the call site can use KALLSYMS to reso= lve the address, but indirect WARN_ON() from a noinline helper needs BUGVER= BOSE for file/line info. This seems intentional. --- Generated by Claude Code Patch Reviewer