From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: arm64: dts: qcom: add support for pixel 3a xl with the tianma panel Date: Sat, 16 May 2026 11:37:16 +1000 Message-ID: In-Reply-To: <20260513172549.1345-3-mailingradian@gmail.com> References: <20260513172549.1345-1-mailingradian@gmail.com> <20260513172549.1345-3-mailingradian@gmail.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Patch Review **Overall:** Clean, minimal device tree for the new variant. Nothing to obj= ect to. **Makefile ordering** is correct =E2=80=94 `bonito` sorts before `sargo` al= phabetically: ``` +dtb-$(CONFIG_ARCH_QCOM) +=3D sdm670-google-bonito-tianma.dtb dtb-$(CONFIG_ARCH_QCOM) +=3D sdm670-google-sargo.dtb ``` **Compatible string** follows the standard most-specific-to-least-specific = pattern: ``` + compatible =3D "google,bonito-tianma", "google,bonito", "qcom,sdm670"; ``` **Device-specific values** all check out against known hardware specs: - Battery: `3700000` =C2=B5Ah (3700mAh, correct for Pixel 3a XL) - Height: `2160` (matches the NT37700F panel binding description: "1080x216= 0 AMOLED") - Panel compatible: `novatek,nt37700f` (binding and driver exist in-tree) - Touchscreen: `69x137` mm (reasonable for 6.0" screen vs sargo's `62x127` = mm for 5.6") **Framebuffer region sizing:** The shared `fb_mem` reserved region is `0x24= 00000` (37.7 MB), which comfortably fits both sargo's 1080=C3=972220=C3=974= =3D 9.6 MB and bonito's 1080=C3=972160=C3=974 =3D 9.3 MB. No issue. **No issues found in this patch.** --- Generated by Claude Code Patch Reviewer