From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: dt-bindings: display: bridge: analogix-dp: Add data-lanes support for endpoint Date: Sat, 16 May 2026 11:13:13 +1000 Message-ID: In-Reply-To: <20260514070133.2275069-3-damon.ding@rock-chips.com> References: <20260514070133.2275069-1-damon.ding@rock-chips.com> <20260514070133.2275069-3-damon.ding@rock-chips.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Patch Review **Status: Minor questions.** The patch adds `data-lanes` at two levels: 1. **Top-level `data-lanes` (deprecated)**: ```yaml + data-lanes: + $ref: /schemas/types.yaml#/definitions/uint32-array + deprecated: true + minItems: 1 + maxItems: 4 + items: + maximum: 3 ``` 2. **Endpoint-level `data-lanes` in `port@1`**: ```yaml + port@1: + ... + properties: + endpoint: + $ref: /schemas/media/video-interfaces.yaml# + unevaluatedProperties: false + properties: + data-lanes: + minItems: 1 + maxItems: 4 + items: + enum: [ 0, 1, 2, 3 ] ``` **Questions/Issues:** - **Top-level deprecated `data-lanes`**: The cover letter doesn't mention b= ackward compatibility with any existing DTS files that use a top-level `dat= a-lanes`. Is there existing hardware using a non-standard top-level `data-l= anes`? If not, adding a deprecated property that was never used seems unnec= essary. If there are existing users, the driver patch (3/3) doesn't parse i= t from the top level at all, only from the endpoint. This should be clarifi= ed in the commit message. - **`enum` vs `maximum`**: The top-level uses `maximum: 3` while the endpoi= nt uses `enum: [0, 1, 2, 3]`. These are functionally equivalent for non-neg= ative integers but the inconsistency is slightly odd. The endpoint style (`= enum`) is more explicit and preferred. - The description change from "Port node with one endpoint connected to a d= p-connector node" to "...sink device node" is fine =E2=80=94 it's more gene= ral and accurate for eDP panels that aren't connector nodes. --- --- Generated by Claude Code Patch Reviewer