From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: crypto: tegra - Don't touch bo refcount in host1x bo pin/unpin
Date: Sat, 16 May 2026 10:12:28 +1000 [thread overview]
Message-ID: <review-patch2-20260515-host1x-bocache-leak-v1-2-a0375f68aeab@nvidia.com> (raw)
In-Reply-To: <20260515-host1x-bocache-leak-v1-2-a0375f68aeab@nvidia.com>
Patch Review
Straightforward follow-up aligning the crypto driver with the new contract:
```c
- map->bo = host1x_bo_get(bo);
+ map->bo = bo;
```
```c
- host1x_bo_put(map->bo);
```
The crypto driver (tegra-se) never uses caching (the `host1x_bo_pin` calls pass `NULL` for cache), so no `host1x_bo_clear_cached_mappings` call is needed. The cmdbuf manages its own lifetime via `cmdbuf->ref`, independent of the host1x_bo refcount.
The cover letter's claim that this is safe to merge independently is correct: without Patch 1, the old `host1x_bo_pin`/`host1x_bo_unpin` don't touch the BO refcount either (it was all in the callbacks), so removing the ref manipulation from both pin and unpin is a no-op from a lifecycle perspective — the crypto driver's own kref on the cmdbuf ensures the BO outlives the mapping.
**No issues with this patch.**
---
Generated by Claude Code Patch Reviewer
next prev parent reply other threads:[~2026-05-16 0:12 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-15 2:34 [PATCH 0/2] Fix leaking of cached Host1x buffer objects Mikko Perttunen
2026-05-15 2:34 ` [PATCH 1/2] gpu: host1x: Allow entries in BO caches to be freed Mikko Perttunen
2026-05-16 0:12 ` Claude review: " Claude Code Review Bot
2026-05-15 2:34 ` [PATCH 2/2] crypto: tegra - Don't touch bo refcount in host1x bo pin/unpin Mikko Perttunen
2026-05-16 0:12 ` Claude Code Review Bot [this message]
2026-05-16 0:12 ` Claude review: Fix leaking of cached Host1x buffer objects Claude Code Review Bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=review-patch2-20260515-host1x-bocache-leak-v1-2-a0375f68aeab@nvidia.com \
--to=claude-review@example.com \
--cc=dri-devel-reviews@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox