From mboxrd@z Thu Jan  1 00:00:00 1970
From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: gpu: nova-core: do not import firmware commands into GSP command module
Date: Sat, 16 May 2026 09:54:07 +1000
Message-ID: <review-patch2-20260515-nova-unload-v5-2-c4d6250ad160@nvidia.com>
In-Reply-To: <20260515-nova-unload-v5-2-c4d6250ad160@nvidia.com>
References: <20260515-nova-unload-v5-0-c4d6250ad160@nvidia.com> <20260515-nova-unload-v5-2-c4d6250ad160@nvidia.com>
X-Mailer: Claude Code Patch Reviewer
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0

Patch Review

Good namespace hygiene change. Replacing `use fw::commands::*` with `use fw::self` makes the origin of each type clear.

```rust
-    fw::{
-        commands::*,
+    fw::{
+        self,
```

The pattern of using `Self::Command::init(...)` instead of repeating the type name is a nice touch:

```rust
-        GspSetSystemInfo::init(self.pdev)
+        Self::Command::init(self.pdev)
```

Clean, no issues.

---

---
Generated by Claude Code Patch Reviewer