public inbox for drm-ai-reviews@public-inbox.freedesktop.org
 help / color / mirror / Atom feed
From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm/bridge: ite-it66121: Move logic .mode_set setup to .atomic_enable
Date: Sat, 16 May 2026 09:32:44 +1000	[thread overview]
Message-ID: <review-patch2-20260515090220.809830-3-javierm@redhat.com> (raw)
In-Reply-To: <20260515090220.809830-3-javierm@redhat.com>

Patch Review

**Good:**
- Correctly moves from the deprecated `.mode_set` to `.atomic_enable`.
- The new `it66121_set_mode` properly extracts the mode from the atomic state through the connector → CRTC → adjusted_mode chain.

**Issue — ordering of `it66121_set_mode` vs `drm_atomic_helper_connector_hdmi_update_infoframes`:**

In the resulting `atomic_enable`:

```c
	drm_atomic_helper_connector_hdmi_update_infoframes(ctx->connector, state);

	it66121_set_mode(ctx, state);
	it66121_set_mute(ctx, false);
```

The infoframes are written *before* the hardware is configured (TX mode, clock bank, AFE, etc.). In the original code, the infoframe write happened in `mode_set` which runs before `atomic_enable`, so the ordering was the same. But logically, writing infoframes before the TX mode is set seems backwards — the hardware should probably be configured first, then infoframes sent. Looking at the register programming sequence (power off TX clock → configure input → configure AFE → power on TX clock → set HDMI mode), infoframes should come *after* the TX path is set up. Consider swapping the order so `it66121_set_mode` runs before the infoframe update. However, if this matches the tested behavior on real hardware, it may be intentional.

**Observation — no error propagation from `it66121_set_mode`:**

The function silently swallows errors via `goto unlock`. This isn't new (the old `mode_set` did the same), but now that it's called from `atomic_enable`, it might be worth at least a `dev_err()` on failure so issues are visible in dmesg.

---
Generated by Claude Code Patch Reviewer

  parent reply	other threads:[~2026-05-15 23:32 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-15  9:02 [PATCH v4 0/3] drm/bridge: ite-it66121: Fix display output for DVI monitors Javier Martinez Canillas
2026-05-15  9:02 ` [PATCH v4 1/3] drm/bridge: ite-it66121: Switch to the HDMI connector helpers Javier Martinez Canillas
2026-05-15  9:23   ` Maxime Ripard
2026-05-15  9:35     ` Javier Martinez Canillas
2026-05-15  9:40   ` Maxime Ripard
2026-05-15 23:32   ` Claude review: " Claude Code Review Bot
2026-05-15  9:02 ` [PATCH v4 2/3] drm/bridge: ite-it66121: Move logic .mode_set setup to .atomic_enable Javier Martinez Canillas
2026-05-15  9:27   ` Maxime Ripard
2026-05-15 23:32   ` Claude Code Review Bot [this message]
2026-05-15  9:02 ` [PATCH v4 3/3] drm/bridge: ite-it66121: Select HDMI or DVI mode based on sink type Javier Martinez Canillas
2026-05-15  9:28   ` Maxime Ripard
2026-05-15 23:32   ` Claude review: " Claude Code Review Bot
2026-05-15 23:32 ` Claude review: drm/bridge: ite-it66121: Fix display output for DVI monitors Claude Code Review Bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=review-patch2-20260515090220.809830-3-javierm@redhat.com \
    --to=claude-review@example.com \
    --cc=dri-devel-reviews@example.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox