From mboxrd@z Thu Jan  1 00:00:00 1970
From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: Re: [PATCH 6.18.y] drm/vkms: Fix ABBA deadlock in vblank disable and timer callback
Date: Tue, 26 May 2026 07:07:31 +1000
Message-ID: <review-patch2-2026051557-thermal-petite-7da0@gregkh>
In-Reply-To: <2026051557-thermal-petite-7da0@gregkh>
References: <20260525131610.608273-1-w15303746062@163.com> <2026051557-thermal-petite-7da0@gregkh>
X-Mailer: Claude Code Patch Reviewer
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0

Patch Review

*(cherry-pick of d54dbb5963bdbdf8559903fe2b2343e871adcb30)*

Adds generic atomic_flush/enable/disable helpers and the `DRM_CRTC_HELPER_V=
BLANK_FUNCS` macro. The implementations are straightforward wrappers:

```c
void drm_crtc_vblank_atomic_enable(struct drm_crtc *crtc, ...) {
    drm_crtc_vblank_on(crtc);
}
void drm_crtc_vblank_atomic_disable(struct drm_crtc *crtc, ...) {
    drm_crtc_vblank_off(crtc);
}
```

The `atomic_flush` helper handles vblank event delivery with proper `event_=
lock` protection and the standard `vblank_get`/`arm` pattern.

**Minor nit:** The doc overview has a typo "coveniently" (should be "conven=
iently") =E2=80=94 inherited from mainline.

No issues. Clean cherry-pick.

---

---
Generated by Claude Code Patch Reviewer