From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm: bridge: dw_hdmi: Only notify connected status on HPD interrupt Date: Mon, 18 May 2026 16:41:45 +1000 Message-ID: In-Reply-To: <20260516183838.2024991-3-jonas@kwiboo.se> References: <20260516183838.2024991-1-jonas@kwiboo.se> <20260516183838.2024991-3-jonas@kwiboo.se> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Patch Review **Status:** Looks correct. Tagged with `Fixes:`. ```c - if (phy_stat & HDMI_PHY_HPD) + if ((intr_stat & HDMI_IH_PHY_STAT0_HPD) && + (phy_stat & HDMI_PHY_HPD)) status = connector_status_connected; ``` Previously, an RX sense change with HPD still high would trigger a false "connected" event during unplug. The added check that the HPD interrupt fired (`intr_stat & HDMI_IH_PHY_STAT0_HPD`) before reporting connected is correct. --- Generated by Claude Code Patch Reviewer