From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: dt-bindings: display: renesas, rzg2l-du: Add RZ/T2H and RZ/N2H support Date: Mon, 25 May 2026 22:39:44 +1000 Message-ID: In-Reply-To: <20260519160825.4082566-3-prabhakar.mahadev-lad.rj@bp.renesas.com> References: <20260519160825.4082566-1-prabhakar.mahadev-lad.rj@bp.renesas.com> <20260519160825.4082566-3-prabhakar.mahadev-lad.rj@bp.renesas.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Patch Review **Status: Good, one minor observation** Adds the new compatible strings and handles the structural differences: - `renesas,r9a09g077-du` for RZ/T2H - `renesas,r9a09g087-du` for RZ/N2H (with RZ/T2H as fallback) The binding groups RZ/T2H with RZ/G2UL for the single-port constraint, whic= h makes sense since both only support port@0 DPI: ```yaml enum: - renesas,r9a07g043u-du - renesas,r9a09g077-du ``` The `resets` handling is well done =E2=80=94 making it conditional via `if/= then/else`: ```yaml - if: properties: compatible: contains: const: renesas,r9a09g077-du then: properties: resets: false else: required: - resets ``` One observation: the `resets` property is removed from the top-level `requi= red` list and made conditionally required via the `else` clause. This means= any *future* SoC added to the binding without updating this `if/else` bloc= k would also get `resets` required, which is the safe default. Good design. Note that patch 2 arrived out of order in the mbox (the mbox has it as the = second message but with subject line "2/5" while the "3/5" patch arrived be= fore it). This is just a mail delivery ordering artifact and doesn't affect= the patches themselves. --- Generated by Claude Code Patch Reviewer