From mboxrd@z Thu Jan  1 00:00:00 1970
From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: PCI/TPH: expose the enabled TPH requester type
Date: Mon, 25 May 2026 22:27:12 +1000
Message-ID: <review-patch2-20260519201401.1558410-3-zhipingz@meta.com>
In-Reply-To: <20260519201401.1558410-3-zhipingz@meta.com>
References: <20260519201401.1558410-1-zhipingz@meta.com> <20260519201401.1558410-3-zhipingz@meta.com>
X-Mailer: Claude Code Patch Reviewer
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0

Patch Review

This is a straightforward accessor:

```c
u8 pcie_tph_enabled_req_type(struct pci_dev *pdev)
{
	return pdev->tph_req_type;
}
EXPORT_SYMBOL(pcie_tph_enabled_req_type);
```

The `!CONFIG_PCIE_TPH` stub returns 0, which matches `PCI_TPH_REQ_DISABLE` =
(defined as `0x0` in `pci_regs.h`):

```c
static inline u8 pcie_tph_enabled_req_type(struct pci_dev *pdev) { return 0=
; }
```

Clean and correct. The `EXPORT_SYMBOL` (not `_GPL`) matches the existing `p=
cie_tph_get_st_table_loc` export convention.

**Nit**: The kdoc says "Return: PCI_TPH_REQ_DISABLE, PCI_TPH_REQ_TPH_ONLY o=
r PCI_TPH_REQ_EXT_TPH" =E2=80=94 note that `PCI_TPH_REQ_EXT_TPH` is `0x3` (=
not `0x2`), so value `0x2` is a gap. The function can technically return an=
y value stored in `tph_req_type`, but the current `pcie_enable_tph` only se=
ts these three. Fine as-is.

---
Generated by Claude Code Patch Reviewer