From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm/display: bridge_connector: init scdc debugfs for HDMI
Date: Mon, 25 May 2026 21:49:33 +1000 [thread overview]
Message-ID: <review-patch2-20260520-scdc-link-health-v2-2-511af18cd64b@collabora.com> (raw)
In-Reply-To: <20260520-scdc-link-health-v2-2-511af18cd64b@collabora.com>
Patch Review
Clean and correct. Just 4 lines adding the SCDC debugfs init call when a bridge has HDMI support.
```c
if (bridge_connector->bridge_hdmi)
drm_scdc_debugfs_init(connector, root);
```
This is placed after the per-bridge `debugfs_init` loop, which is the right location. The `drm_scdc_debugfs_init` function already handles NULL checks and allocation failure gracefully.
No issues with this patch.
---
Generated by Claude Code Patch Reviewer
next prev parent reply other threads:[~2026-05-25 11:49 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-20 13:35 [PATCH v2 0/3] Add SCDC information to connector debugfs Nicolas Frattaroli
2026-05-20 13:35 ` [PATCH v2 1/3] drm/scdc-helper: Add scdc_status debugfs entry Nicolas Frattaroli
2026-05-25 11:49 ` Claude review: " Claude Code Review Bot
2026-05-20 13:35 ` [PATCH v2 2/3] drm/display: bridge_connector: init scdc debugfs for HDMI Nicolas Frattaroli
2026-05-25 11:49 ` Claude Code Review Bot [this message]
2026-05-20 13:35 ` [PATCH v2 3/3] drm/scdc-helper: Implement parsing and printing HDMI 2.1 fields Nicolas Frattaroli
2026-05-22 17:38 ` Daniel Stone
2026-05-25 11:49 ` Claude review: " Claude Code Review Bot
2026-05-25 11:49 ` Claude review: Add SCDC information to connector debugfs Claude Code Review Bot
-- strict thread matches above, loose matches on Subject: below --
2026-05-26 10:19 [PATCH v3 0/4] " Nicolas Frattaroli
2026-05-26 10:19 ` [PATCH v3 3/4] drm/display: bridge_connector: init scdc debugfs for HDMI Nicolas Frattaroli
2026-05-27 5:01 ` Claude review: " Claude Code Review Bot
2026-05-27 14:03 [PATCH v4 0/4] Add SCDC information to connector debugfs Nicolas Frattaroli
2026-05-27 14:03 ` [PATCH v4 3/4] drm/display: bridge_connector: init scdc debugfs for HDMI Nicolas Frattaroli
2026-05-28 2:16 ` Claude review: " Claude Code Review Bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=review-patch2-20260520-scdc-link-health-v2-2-511af18cd64b@collabora.com \
--to=claude-review@example.com \
--cc=dri-devel-reviews@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox