From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: arm64: dts: qcom: sc8280xp-arcata: Enable backlight Date: Mon, 25 May 2026 21:20:08 +1000 Message-ID: In-Reply-To: <20260520-surface-sp9-5g-for-next-v1-2-9df52552bf87@gmail.com> References: <20260520-surface-sp9-5g-for-next-v1-0-9df52552bf87@gmail.com> <20260520-surface-sp9-5g-for-next-v1-2-9df52552bf87@gmail.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Patch Review **No issues.** The backlight node matches the X13s pattern exactly (same PW= M channel, same enable GPIO on `pmc8280_1_gpios 8`). The key difference =E2= =80=94 the backlight regulator enable on `pmc8280c_gpios 6` instead of the = X13s's `pmc8280_1_gpios 9` =E2=80=94 is well explained in the commit messag= e via GPIO debugging output comparison. The pinctrl definitions look correc= t: ``` gpio =3D <&pmc8280c_gpios 6 GPIO_ACTIVE_HIGH>; ``` The `regulator-boot-on` on `vreg_edp_bl` is appropriate for keeping the dis= play lit during boot. --- Generated by Claude Code Patch Reviewer