From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: misc: fastrpc: Replace hardcoded ctxid mask with GENMASK Date: Mon, 25 May 2026 22:12:29 +1000 Message-ID: In-Reply-To: <20260520065047.3415790-3-ekansh.gupta@oss.qualcomm.com> References: <20260520065047.3415790-1-ekansh.gupta@oss.qualcomm.com> <20260520065047.3415790-3-ekansh.gupta@oss.qualcomm.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Patch Review **Overall: Looks good.** Clean mechanical conversion. The patch adds `#include ` (though `` wou= ld be more precise for `FIELD_PREP`/`FIELD_GET` =E2=80=94 but `bitops.h` do= es pull in what's needed via `bits.h` which was already included). Conversions are correct: - `ctx->ctxid >> 4` =E2=86=92 `FIELD_GET(FASTRPC_CTXID_MASK, ctx->ctxid)` = =E2=80=94 correct, GENMASK(11,4) with FIELD_GET extracts bits [11:4] shifte= d down. - `ret << 4` =E2=86=92 `FIELD_PREP(FASTRPC_CTXID_MASK, ret)` =E2=80=94 corr= ect. - `(rsp->ctx & FASTRPC_CTXID_MASK) >> 4` =E2=86=92 `FIELD_GET(FASTRPC_CTXID= _MASK, rsp->ctx)` =E2=80=94 correct. **Minor nit:** The added include is `linux/bitops.h` but `FIELD_PREP`/`FIEL= D_GET` are from `linux/bitfield.h`. This likely works because of transitive= includes, but `linux/bitfield.h` would be the canonical include for these = macros. --- --- Generated by Claude Code Patch Reviewer