From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/exec: Make the drm_exec_until_all_locked() macro more readable Date: Mon, 25 May 2026 21:59:35 +1000 Message-ID: In-Reply-To: <20260520101616.41284-3-thomas.hellstrom@linux.intel.com> References: <20260520101616.41284-1-thomas.hellstrom@linux.intel.com> <20260520101616.41284-3-thomas.hellstrom@linux.intel.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Patch Review **Assessment: Good.** ```c #define __drm_exec_until_all_locked(exec, _label) \ _label: \ for (void *const __maybe_unused __drm_exec_retry_ptr =3D &&_label; \ drm_exec_cleanup(exec);) ``` Three improvements here: 1. `__UNIQUE_ID` for the label name instead of `__PASTE(__drm_exec_, __LINE= __)` =E2=80=94 consistent with patch 1 and standard kernel idiom. 2. `__maybe_unused` instead of `(void)__drm_exec_retry_ptr` cast =E2=80=94 = cleaner. 3. `void *const` =E2=80=94 prevents accidental reassignment of the jump tar= get. Note that `__drm_exec_retry_ptr` itself is deliberately *not* uniquified, s= ince `drm_exec_retry_on_contention()` (and the new `drm_exec_retry()` from = patch 3) reference it by name. This is the correct design =E2=80=94 the var= iable name forms the contract between the loop macro and the retry macros. One minor observation: the comment block is moved from the `drm_exec_until_= all_locked` kdoc to the helper, which is appropriate since the implementati= on detail about label scoping belongs with the helper. --- Generated by Claude Code Patch Reviewer