From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: fbdev: Wrap user-invoked calls to fb_blank() in helper Date: Mon, 25 May 2026 21:30:31 +1000 Message-ID: In-Reply-To: <20260520160744.130841-3-tzimmermann@suse.de> References: <20260520160744.130841-1-tzimmermann@suse.de> <20260520160744.130841-3-tzimmermann@suse.de> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Patch Review **Correctness**: The new `fb_blank_from_user()` correctly wraps `fb_blank()= ` + `fbcon_fb_blanked()`. The pattern is preserved faithfully =E2=80=94 `fb= con_fb_blanked` is called regardless of whether `fb_blank` returned an erro= r, matching the original behavior in both the ioctl and sysfs paths. **Scope**: The function is declared in `fb_internal.h` rather than `fb.h`, = which is appropriate since both callers (`fb_chrdev.c`, `fbsysfs.c`) are wi= thin the fbdev core. No external drivers need this. Good. **No concerns** with this patch. --- Generated by Claude Code Patch Reviewer