From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: gpu: nova-core: do not import firmware commands into GSP command module Date: Mon, 25 May 2026 20:06:41 +1000 Message-ID: In-Reply-To: <20260521-nova-unload-v6-2-65f581c812c9@nvidia.com> References: <20260521-nova-unload-v6-0-65f581c812c9@nvidia.com> <20260521-nova-unload-v6-2-65f581c812c9@nvidia.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Patch Review Good namespace hygiene. Replacing `use fw::commands::*` with `use fw::self` and then qualifying all types as `fw::commands::GspSetSystemInfo` etc. makes the code clearer about which layer each type belongs to. The use of `Self::Command` in `init()` methods (e.g., `Self::Command::init(self.pdev)` instead of `GspSetSystemInfo::init(self.pdev)`) is a nice pattern that ties the init call to the associated type. No issues. --- --- Generated by Claude Code Patch Reviewer