public inbox for drm-ai-reviews@public-inbox.freedesktop.org
 help / color / mirror / Atom feed
From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm/panthor: Reduce padding in gems debugfs for refcount
Date: Mon, 25 May 2026 20:03:23 +1000	[thread overview]
Message-ID: <review-patch2-20260521-panthor-bo-reclaim-observability-v5-2-49313994da55@collabora.com> (raw)
In-Reply-To: <20260521-panthor-bo-reclaim-observability-v5-2-49313994da55@collabora.com>

Patch Review

This is a purely cosmetic patch that reduces the refcount column width from 16 to 11 characters:

```c
-	seq_printf(m, "%-32s%-16d%-11d%-11d%-16zd%-16zd0x%-16lx",
+	seq_printf(m, "%-32s%-16d%-11d%-11d%-16zd%-16zd0x%-16lx",
```

Wait — looking more carefully at the diff: in the base from patch 1, the format string was `%-16d` for refcount, and this patch changes it to `%-11d`. The header/separator lines are updated consistently to match the narrower column.

The rationale is sound: `kref_read` returns an `unsigned int`, but realistically refcount values are small. The commit message says it "can only ever contain a 10-digit decimal number" (UINT_MAX is 4294967295, 10 digits), so 11 chars (10 + separator) is correct.

The header, separator, and footer lines are all consistently shortened by 5 characters. Looks correct.

Already has `Reviewed-by: Steven Price <steven.price@arm.com>`.

**No issues with this patch.**

---
Generated by Claude Code Patch Reviewer

  reply	other threads:[~2026-05-25 10:03 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-21 13:51 [PATCH v5 0/2] Let userspace know about swapped out panthor GEM objects Nicolas Frattaroli
2026-05-21 13:51 ` [PATCH v5 1/2] drm/panthor: Implement evicted status for " Nicolas Frattaroli
2026-05-21 14:44   ` Nicolas Frattaroli
2026-05-25 10:03   ` Claude review: " Claude Code Review Bot
2026-05-21 13:51 ` [PATCH v5 2/2] drm/panthor: Reduce padding in gems debugfs for refcount Nicolas Frattaroli
2026-05-25 10:03   ` Claude Code Review Bot [this message]
2026-05-25 10:03 ` Claude review: Let userspace know about swapped out panthor GEM objects Claude Code Review Bot
  -- strict thread matches above, loose matches on Subject: below --
2026-05-20 13:04 [PATCH v4 0/3] " Nicolas Frattaroli
2026-05-20 13:04 ` [PATCH v4 3/3] drm/panthor: Reduce padding in gems debugfs for refcount Nicolas Frattaroli
2026-05-25 11:52   ` Claude review: " Claude Code Review Bot
2026-04-21 10:45 [PATCH v2 0/3] Let userspace know about swapped out panthor GEM objects Nicolas Frattaroli
2026-04-21 10:45 ` [PATCH v2 3/3] drm/panthor: Reduce padding in gems debugfs for refcount Nicolas Frattaroli
2026-04-22 22:36   ` Claude review: " Claude Code Review Bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=review-patch2-20260521-panthor-bo-reclaim-observability-v5-2-49313994da55@collabora.com \
    --to=claude-review@example.com \
    --cc=dri-devel-reviews@example.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox