From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/bridge: aux: Add drm_aux_bridge_register_from_node() Date: Mon, 25 May 2026 21:00:52 +1000 Message-ID: In-Reply-To: <20260521032854.103-3-kernel@airkyi.com> References: <20260521032854.103-1-kernel@airkyi.com> <20260521032854.103-3-kernel@airkyi.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Patch Review Clean patch. The refactoring to make `drm_aux_bridge_register()` a wrapper = around the new `_from_node()` variant is the right approach. **Minor nit:** The kdoc on the original `drm_aux_bridge_register()` is upda= ted to add `@np` but that parameter doesn't exist on the old function =E2= =80=94 the `@np` doc belongs only on the new `drm_aux_bridge_register_from_= node()`. Looking more carefully: ```c /** * drm_aux_bridge_register - Create a simple bridge device to link the chain * @parent: device instance providing this bridge * @np: device node pointer corresponding to this bridge instance ``` This kdoc block is placed on `drm_aux_bridge_register_from_node()` after th= e rename, so the function name in the doc comment (`drm_aux_bridge_register= `) is now wrong =E2=80=94 it should say `drm_aux_bridge_register_from_node`= . The `@np` parameter description should also mention that NULL falls back = to the parent device's of_node. --- Generated by Claude Code Patch Reviewer