From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm: writeback: Modify writeback init helpers Date: Mon, 25 May 2026 20:57:35 +1000 Message-ID: In-Reply-To: <20260521053708.1475129-3-suraj.kandpal@intel.com> References: <20260521053708.1475129-1-suraj.kandpal@intel.com> <20260521053708.1475129-3-suraj.kandpal@intel.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Patch Review Changes `drm_writeback_connector_init()` and `drmm_writeback_connector_init= ()` to take `struct drm_connector *` instead of `struct drm_writeback_conne= ctor *`. Clean and correct. All driver callsites are updated consistently. **Minor issues:** 1. **Comment says "Drm connector"** =E2=80=94 kernel convention is lowercas= e "DRM": ```c * @connector: Drm connector which contains the writeback connector to in= itialize ``` Should be `DRM connector` or just `drm_connector`. 2. The `__drm_writeback_connector_init()` internal helper is *not* updated = in this patch =E2=80=94 it still takes `drm_writeback_connector *`. This is= fine since it's static and called from the now-updated public wrappers, bu= t it creates an inconsistency in the internal API. A follow-up could clean = this up. --- Generated by Claude Code Patch Reviewer