From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: misc: fastrpc: Replace hardcoded ctxid mask with GENMASK Date: Mon, 25 May 2026 20:54:21 +1000 Message-ID: In-Reply-To: <20260521054539.128651-3-ekansh.gupta@oss.qualcomm.com> References: <20260521054539.128651-1-ekansh.gupta@oss.qualcomm.com> <20260521054539.128651-3-ekansh.gupta@oss.qualcomm.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Patch Review **Status: Looks good.** Straightforward cleanup replacing `0xFF0` with `GENMASK(11, 4)` and manual = shifts with `FIELD_PREP`/`FIELD_GET`. The `#include ` is ad= ded but `FIELD_PREP`/`FIELD_GET` are from `` =E2=80=94 ho= wever, `bitfield.h` is likely pulled in transitively already since the code= compiles. Minor nit but not a blocker if it builds. Has R-b from both Konrad Dybcio and Dmitry Baryshkov. No issues. --- Generated by Claude Code Patch Reviewer