From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/managed: fix drmm_add_mod_or_reset() kernel-doc Date: Mon, 25 May 2026 19:48:11 +1000 Message-ID: In-Reply-To: <20260521155231.1821935-3-michal.grzelak@intel.com> References: <20260521155231.1821935-1-michal.grzelak@intel.com> <20260521155231.1821935-3-michal.grzelak@intel.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Patch Review **Correctness: Good.** The existing kernel-doc at `include/drm/drm_managed.= h:21` says: ``` * This function adds the @release action with optional parameter @data to = the ``` The parameter is named `action`, not `release` =E2=80=94 there is no `@rele= ase` parameter in the argument list (lines 17-18 list `@dev`, `@action`, `@= data`). The fix correctly changes this to: ``` * This function adds the release @action with optional parameter @data to = the ``` This is the right fix =E2=80=94 `@action` now correctly references the docu= mented parameter. **Minor nit:** The commit subject says "drmm_add_mod_or_reset()" but the ac= tual macro is `drmm_add_action` (line 25 of `drm_managed.h`). The kernel-do= c comment block at line 16 is for `drmm_add_action`, not `drmm_add_action_o= r_reset` (which has its own doc block starting at line 32). The subject lin= e appears to have a typo =E2=80=94 it should say `drmm_add_action()`. The s= ame doc issue also exists in the `drmm_add_action_or_reset` block at line 3= 8-39 (`@release` should be `@action` there too), but that's not addressed i= n this patch. **Summary:** Both patches are correct and should be applied. The only sugge= stion is fixing the commit subject typo in patch 2, and optionally fixing t= he same `@release` =E2=86=92 `@action` issue in the `drmm_add_action_or_res= et` doc block while at it. --- Generated by Claude Code Patch Reviewer