From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: bus: mhi: Drop controller runtime PM callback indirection Date: Mon, 25 May 2026 19:03:04 +1000 Message-ID: In-Reply-To: <20260522-mhi_runtimepm-v2-2-fbebf41a82bb@oss.qualcomm.com> References: <20260522-mhi_runtimepm-v2-0-fbebf41a82bb@oss.qualcomm.com> <20260522-mhi_runtimepm-v2-2-fbebf41a82bb@oss.qualcomm.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Patch Review Clean removal of the `runtime_get`/`runtime_put` function pointers from `struct mhi_controller` and all driver-side implementations. The removed implementations were either no-ops (qaic, ath11k, ath12k) or trivial wrappers (pci_generic). The `mhi_pci_generic_edl_trigger` conversion is correct - it was the one remaining caller that went through the callbacks, and it's properly switched to direct API calls. One observation: there's a stray blank line left behind in `ath11k/mhi.c`: ```c -static void ath11k_mhi_op_runtime_put(struct mhi_controller *mhi_cntrl) -{ -} static char *ath11k_mhi_op_callback_to_str(enum mhi_callback reason) ``` This leaves a double blank line. Minor style nit. No functional issues. --- Generated by Claude Code Patch Reviewer