From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm: writeback: Modify writeback init helpers Date: Mon, 25 May 2026 19:19:15 +1000 Message-ID: In-Reply-To: <20260522050313.1800378-3-suraj.kandpal@intel.com> References: <20260522050313.1800378-1-suraj.kandpal@intel.com> <20260522050313.1800378-3-suraj.kandpal@intel.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Patch Review Changes `drm_writeback_connector_init()` and `drmm_writeback_connector_init()` to take `struct drm_connector *` instead of `struct drm_writeback_connector *`, and updates all callers. **Analysis:** Straightforward and correct. The internal implementation now does: ```c + struct drm_writeback_connector *wb_connector = &connector->writeback; ``` instead of: ```c - struct drm_connector *connector = drm_writeback_to_connector(wb_connector); ``` All driver call sites are updated consistently. The komeda driver properly removes the now-unnecessary `wb_conn` local variable. No issues. --- Generated by Claude Code Patch Reviewer