From mboxrd@z Thu Jan  1 00:00:00 1970
From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: gpu/buddy: Remove redundant condition in alloc_from_freetree() error path
Date: Mon, 25 May 2026 19:06:37 +1000
Message-ID: <review-patch2-20260522092600.32818-3-francois.dugast@intel.com>
In-Reply-To: <20260522092600.32818-3-francois.dugast@intel.com>
References: <20260522092600.32818-1-francois.dugast@intel.com> <20260522092600.32818-3-francois.dugast@intel.com>
X-Mailer: Claude Code Patch Reviewer
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0

Patch Review

**Correctness: Correct cleanup.**

The `err_undo` label is only reachable from inside the `while (tmp !=3D ord=
er)` loop (via `goto err_undo` at line 842). At that point `tmp` is guarant=
eed to differ from `order` =E2=80=94 if they were equal, the loop wouldn't =
have been entered. Removing the guard is safe.

```c
err_undo:
	rbtree_remove(mm, block);
	__gpu_buddy_free(mm, block, false);
```

This is a straightforward simplification. No issues.

---
Generated by Claude Code Patch Reviewer