From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: fbdev: Wrap user-invoked calls to fb_blank() in helper Date: Mon, 25 May 2026 18:52:08 +1000 Message-ID: In-Reply-To: <20260522123019.211059-3-tzimmermann@suse.de> References: <20260522123019.211059-1-tzimmermann@suse.de> <20260522123019.211059-3-tzimmermann@suse.de> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Patch Review Creates `fb_blank_from_user()` in `fbmem.c` that bundles `fb_blank()` + `fb= con_fb_blanked()`. The helper correctly preserves the existing behavior of calling `fbcon_fb_b= lanked()` unconditionally (even when `fb_blank()` fails), which matches bot= h the chrdev and sysfs callers. The declaration is placed in `fb_internal.h` rather than `fb.h` =E2=80=94 t= his is appropriate since `fb_blank_from_user` is only called from within th= e fbdev core (chrdev and sysfs), unlike `fb_set_var_from_user` which is als= o called from external drivers. The existing locking difference between chrdev (uses `lock_fb_info`) and sy= sfs (does not use `lock_fb_info`) is preserved by this patch. This is a pre= -existing inconsistency, not introduced here. Removal of `#include ` from `fbsysfs.c` is correct =E2=80=94= it no longer directly calls any fbcon functions. **No issues.** --- Generated by Claude Code Patch Reviewer