From mboxrd@z Thu Jan  1 00:00:00 1970
From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm/managed: fix drmm_add_action() kernel-doc
Date: Mon, 25 May 2026 18:29:27 +1000
Message-ID: <review-patch2-20260522135520.1862848-3-michal.grzelak@intel.com>
In-Reply-To: <20260522135520.1862848-3-michal.grzelak@intel.com>
References: <20260522135520.1862848-1-michal.grzelak@intel.com> <20260522135520.1862848-3-michal.grzelak@intel.com>
X-Mailer: Claude Code Patch Reviewer
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0

Patch Review

This patch fixes a kernel-doc `@parameter` reference error in the `drmm_add=
_action()` macro documentation.

**Before:**
```c
 * This function adds the @release action with optional parameter @data to =
the
```

**After:**
```c
 * This function adds the release @action with optional parameter @data to =
the
```

The macro's parameters are `dev`, `action`, and `data`. The old text used `=
@release`, which is not a parameter =E2=80=94 kernel-doc would flag this as=
 an undocumented/invalid reference. The fix swaps the `@` to correctly anno=
tate `@action` (the actual parameter) and makes `release` a plain descripti=
ve word. This is correct.

I confirmed by reading `include/drm/drm_managed.h:15-26` =E2=80=94 the macr=
o is:
```c
#define drmm_add_action(dev, action, data) \
	__drmm_add_action(dev, action, data, #action)
```

The parameter list is `@dev`, `@action`, `@data` =E2=80=94 matching the cor=
rected doc.

**Reviewed-by worthy:** Yes.

---
Generated by Claude Code Patch Reviewer