From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/radeon/radeon_connectors: remove radeon_connector_free_edid Date: Mon, 25 May 2026 17:37:45 +1000 Message-ID: In-Reply-To: <20260523142748.50034-3-jpeisach@ubuntu.com> References: <20260523142748.50034-1-jpeisach@ubuntu.com> <20260523142748.50034-3-jpeisach@ubuntu.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Patch Review **Approach:** Removes the `radeon_connector_free_edid()` helper and replace= s all call sites with inline `drm_edid_free()` + NULL assignment. This is t= he right thing to do since `drm_edid_free()` is a standard API function. **The transformation is mechanical and correct** =E2=80=94 every call site = is replaced with the same two-line pattern: ```c drm_edid_free(radeon_connector->edid); radeon_connector->edid =3D NULL; ``` **Minor observation:** The NULL assignment after `drm_edid_free()` is good = practice but is technically unnecessary in the `radeon_connector_destroy()`= path since the connector struct itself is about to be freed. Not worth cha= nging, just noting. **Ordering concern:** As mentioned above, this patch fixes the correctness = problem created by patch 1 (where `kfree` was being called on `struct drm_e= did *`). The series would be cleaner if either: (a) patch 1 updates `radeon= _connector_free_edid` to use `drm_edid_free()` internally, or (b) the two p= atches are squashed. As submitted, bisecting to the state after only patch = 1 produces broken code. --- **Summary:** The API migration is correctly done and the final state after = both patches is correct. The main concern is the bisectability issue: after= patch 1 alone, `kfree()` is called on `const struct drm_edid *`, which is = both a memory leak (inner edid not freed) and a const-correctness violation= . Recommend either squashing or fixing the `radeon_connector_free_edid` bod= y in patch 1. --- Generated by Claude Code Patch Reviewer