From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/colorop: make lut(1/3)d_interpolation mutable Date: Tue, 26 May 2026 07:18:46 +1000 Message-ID: In-Reply-To: <20260525100524.304263-3-mwen@igalia.com> References: <20260525100524.304263-1-mwen@igalia.com> <20260525100524.304263-3-mwen@igalia.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Patch Review Moves `lut1d_interpolation` and `lut3d_interpolation` from `struct drm_colorop` (immutable hardware object) to `struct drm_colorop_state` (per-commit mutable state). All the right places are updated: - **State print** (`drm_atomic_colorop_print_state`): reads from `state->` instead of `colorop->`. - **Set/get property**: reads/writes `state->` instead of `colorop->`. - **Init functions** (`drm_plane_colorop_curve_1d_lut_init`, `drm_plane_colorop_3dlut_init`): removes assignment to `colorop->lut1d/3d_interpolation` since it's now state. - **State reset** (`__drm_colorop_state_reset`): initializes new state fields from property defaults via `drm_object_property_get_default_value()`. The state reset correctly uses the same pattern as the existing `curve_1d_type` initialization. No issues. --- --- Generated by Claude Code Patch Reviewer