From mboxrd@z Thu Jan  1 00:00:00 1970
From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm/vblank: Add CRTC helpers for simple use cases
Date: Wed, 27 May 2026 14:49:44 +1000
Message-ID: <review-patch2-20260526133123.691465-3-w15303746062@163.com>
In-Reply-To: <20260526133123.691465-3-w15303746062@163.com>
References: <20260526133123.691465-1-w15303746062@163.com> <20260526133123.691465-3-w15303746062@163.com>
X-Mailer: Claude Code Patch Reviewer
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0

Patch Review

Cherry-pick of upstream `d54dbb5963bdbdf8559903fe2b2343e871adcb30`.

Adds `drm_crtc_vblank_atomic_flush()`, `drm_crtc_vblank_atomic_enable()`, and `drm_crtc_vblank_atomic_disable()` as generic CRTC helper callbacks, plus the `DRM_CRTC_HELPER_VBLANK_FUNCS` macro.

The `atomic_flush` implementation correctly handles the vblank event arming pattern:
```c
if (drm_crtc_vblank_get(crtc) == 0)
    drm_crtc_arm_vblank_event(crtc, event);
else
    drm_crtc_send_vblank_event(crtc, event);
```
This is the standard pattern used across DRM drivers.

**No issues.**

---
Generated by Claude Code Patch Reviewer