Claude review: drm/atomic: duplicate state of all colorops

[Claude Code Review Bot <claude-review@example.com>]

Patch Review

**Purpose:** In `drm_atomic_helper_duplicate_state()`, remove the `if (plane_state->color_pipeline)` guard so that **all** colorops are snapshotted regardless of whether a pipeline is currently active. This ensures colorop settings persist across deactivation/reactivation.

**The change is straightforward and correct:**

```c
-       if (plane_state->color_pipeline) {
-           err = drm_atomic_add_affected_colorops(state, plane);
-           if (err)
-               goto free;
-       }
-
+       err = drm_atomic_add_affected_colorops(state, plane);
+       if (err)
+           goto free;
```

**Minor concern — interaction with Patch 1:**  Patch 1 introduces `drm_atomic_add_pipeline_colorops()` for use in `drm_atomic_add_affected_planes()` (which only adds active/transitioning colorops), while this patch keeps `drm_atomic_add_affected_colorops()` here (which adds all colorops on the plane). The two functions serve legitimately different purposes, but having two similarly-named functions with different semantics could be confusing. A comment in the code or in the commit message acknowledging this intentional distinction would help.

**No bugs found.** The change correctly ensures persistence of colorop state across pipeline deactivation.

---

---
Generated by Claude Code Patch Reviewer