From mboxrd@z Thu Jan  1 00:00:00 1970
From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: rust: gem: shmem: Fix Default implementation for ObjectConfig
Date: Wed, 27 May 2026 14:05:18 +1000
Message-ID: <review-patch2-20260526212857.1158294-3-lyude@redhat.com>
In-Reply-To: <20260526212857.1158294-3-lyude@redhat.com>
References: <20260526212857.1158294-1-lyude@redhat.com> <20260526212857.1158294-3-lyude@redhat.com>
X-Mailer: Claude Code Patch Reviewer
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0

Patch Review

**Status: Looks good**

Correct fix. `#[derive(Default)]` requires all generic parameters to implement `Default`, which is unnecessarily restrictive here since `T` is only used in `PhantomData`-like positions (the `Option<&'a Object<T>>`):

```rust
+impl<'a, T: DriverObject> Default for ObjectConfig<'a, T> {
+    #[inline(always)]
+    fn default() -> Self {
+        Self {
+            map_wc: false,
+            parent_resv_obj: None,
+        }
+    }
+}
```

The `#[inline(always)]` is fine for a trivial constructor. Default values are correct (`false` for `map_wc`, `None` for `parent_resv_obj`).

---
Generated by Claude Code Patch Reviewer