From mboxrd@z Thu Jan  1 00:00:00 1970
From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: pin_init: always inline the #ident and #project_ident methods
Date: Thu, 28 May 2026 12:22:00 +1000
Message-ID: <review-patch2-20260527-nova-exports-v2-2-06de4c556d55@nvidia.com>
In-Reply-To: <20260527-nova-exports-v2-2-06de4c556d55@nvidia.com>
References: <20260527-nova-exports-v2-0-06de4c556d55@nvidia.com> <20260527-nova-exports-v2-2-06de4c556d55@nvidia.com>
X-Mailer: Claude Code Patch Reviewer
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0

Patch Review

Small, mechanical patch adding `#[inline(always)]` to two generated methods in `pin_data.rs`:

```rust
#[inline(always)]
#vis unsafe fn #ident<E>(
```

```rust
#[inline(always)]
#vis unsafe fn #project_ident<'__slot>(
```

These are proc-macro-generated methods that form part of the pin initialization infrastructure. Adding `#[inline(always)]` is reasonable for methods that are small delegation wrappers and whose mangled names would otherwise consume the 500-byte `buf_printf` buffer.

**No issues.** This should be reviewed/acked by the pin-init maintainer (Benno Lossin).

---
Generated by Claude Code Patch Reviewer