From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: fbdev: Wrap user-invoked calls to fb_blank() in helper Date: Thu, 28 May 2026 12:12:51 +1000 Message-ID: In-Reply-To: <20260527151551.258659-3-tzimmermann@suse.de> References: <20260527151551.258659-1-tzimmermann@suse.de> <20260527151551.258659-3-tzimmermann@suse.de> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Patch Review Clean and correct. The new `fb_blank_from_user()` in `fbmem.c` faithfully replicates the original calling pattern: ```c int ret = fb_blank(info, blank); /* might again call into fb_blank */ fbcon_fb_blanked(info, blank); return ret; ``` The unconditional call to `fbcon_fb_blanked` regardless of `fb_blank`'s return value matches the original behavior in both `fb_chrdev.c` and `fbsysfs.c`. Declared in `fb_internal.h` since it's only called from within fbdev core. No issues. --- Generated by Claude Code Patch Reviewer