From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/atomic-helpers: Evaluate plane damage after atomic_check Date: Thu, 04 Jun 2026 15:21:21 +1000 Message-ID: In-Reply-To: <20260530185716.65688-3-tzimmermann@suse.de> References: <20260530185716.65688-1-tzimmermann@suse.de> <20260530185716.65688-3-tzimmermann@suse.de> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Patch Review Adds a second call to `drm_atomic_helper_check_plane_damage()` **after** all plane and CRTC `atomic_check` callbacks: ```c + for_each_oldnew_plane_in_state(state, plane, old_plane_state, new_plane_state, i) { + drm_atomic_helper_check_plane_damage(state, new_plane_state); + } ``` This is deliberately placed after the CRTC atomic_check loop too, so any modeset triggered by either plane or CRTC checks is caught. The existing pre-check call is left in place for now (removed in patch 5) to keep the series bisectable. The braces around the single-statement `for_each_oldnew_plane_in_state` body are consistent with kernel style for macro-based iterators. **No issues.** --- Generated by Claude Code Patch Reviewer