public inbox for drm-ai-reviews@public-inbox.freedesktop.org
 help / color / mirror / Atom feed
From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm/tidss: Open-code drm_simple_encoder_init()
Date: Thu, 04 Jun 2026 15:05:00 +1000	[thread overview]
Message-ID: <review-patch2-20260531073532.8609-3-namanarora029@gmail.com> (raw)
In-Reply-To: <20260531073532.8609-3-namanarora029@gmail.com>

Patch Review

**Correctness: OK**

Same mechanical transformation. The new struct `tidss_drm_encoder_funcs` is placed after `tidss_bridge_funcs` and before `tidss_encoder_create()`, which is the correct placement. The `encoder_type` parameter is correctly forwarded from the function argument.

Reviewed-by worthy.

---
Generated by Claude Code Patch Reviewer

  reply	other threads:[~2026-06-04  5:05 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-31  7:35 [PATCH 0/6] drm: Open-code drm_simple_encoder_init() in several drivers Naman Arora
2026-05-31  7:35 ` [PATCH 1/6] drm/fsl-dcu: Open-code drm_simple_encoder_init() Naman Arora
2026-06-04  5:05   ` Claude review: " Claude Code Review Bot
2026-05-31  7:35 ` [PATCH 2/6] drm/tidss: " Naman Arora
2026-06-04  5:05   ` Claude Code Review Bot [this message]
2026-05-31  7:35 ` [PATCH 3/6] drm/virtio: " Naman Arora
2026-06-04  5:05   ` Claude review: " Claude Code Review Bot
2026-05-31  7:46 ` [PATCH 4/6] drm/meson: Open-code drm_simple_encoder_init() in encoder_cvbs Naman Arora
2026-05-31  7:46   ` [PATCH 5/6] drm/meson: Open-code drm_simple_encoder_init() in encoder_hdmi Naman Arora
2026-06-04  5:05     ` Claude review: " Claude Code Review Bot
2026-05-31  7:46   ` [PATCH 6/6] drm/meson: Open-code drm_simple_encoder_init() in encoder_dsi Naman Arora
2026-06-04  5:05     ` Claude review: " Claude Code Review Bot
2026-06-04  5:05   ` Claude review: drm/meson: Open-code drm_simple_encoder_init() in encoder_cvbs Claude Code Review Bot
2026-06-04  5:05 ` Claude review: drm: Open-code drm_simple_encoder_init() in several drivers Claude Code Review Bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=review-patch2-20260531073532.8609-3-namanarora029@gmail.com \
    --to=claude-review@example.com \
    --cc=dri-devel-reviews@example.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox