From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: backlight: add kernel-internal backlight API
Date: Thu, 04 Jun 2026 14:54:30 +1000 [thread overview]
Message-ID: <review-patch2-20260531114908.1693426-3-superm1@kernel.org> (raw)
In-Reply-To: <20260531114908.1693426-3-superm1@kernel.org>
Patch Review
**Concern: Double notification in backlight_set_brightness**
`backlight_set_brightness` calls `backlight_update_status(bd)` and then `backlight_generate_event()`. But in patch 3, `backlight_update_status` is modified to also call `backlight_notify_brightness()`. This means a single `backlight_set_brightness` call will:
1. Call `backlight_update_status` → which calls `backlight_notify_brightness` (notifier chain)
2. Then call `backlight_generate_event` (uevent)
3. The notifier from step 1 fires `__drm_backlight_real_changed` which is supposed to update the DRM property
The `backlight_generate_event` call here is arguably correct (it sends a uevent), but the interaction with the notifier added in patch 3 creates a loop risk: DRM sets brightness → `backlight_set_brightness` → `backlight_update_status` → `backlight_notify_brightness` → DRM notifier → `__drm_backlight_real_changed`. The `__drm_backlight_real_changed` function updates `connector->state->luminance` under spinlock, which should be safe, but it's worth verifying there's no re-entrant path.
**Concern: ops_lock held across backlight_generate_event**
```c
+ guard(mutex)(&bd->ops_lock);
+ if (bd->ops) {
+ if (value > bd->props.max_brightness)
+ return -EINVAL;
+ bd->props.brightness = value;
+ rc = backlight_update_status(bd);
+ }
+ if (rc == 0)
+ backlight_generate_event(bd, reason);
```
`backlight_generate_event` calls `kobject_uevent_env` which can sleep and allocate. It's called with `ops_lock` held (via `guard`). While `ops_lock` is a mutex so sleeping is OK, holding it longer than necessary across a uevent broadcast isn't ideal. But it's not a correctness bug.
**Minor**: `backlight_set_brightness` sends a uevent even when `bd->ops` is NULL (rc stays 0 in that case). Should it return early if ops is NULL?
---
Generated by Claude Code Patch Reviewer
next prev parent reply other threads:[~2026-06-04 4:54 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-31 11:48 [PATCH v5 00/11] Add support for a DRM backlight capability Mario Limonciello (AMD)
2026-05-31 11:48 ` [PATCH v5 01/11] Revert "backlight: Remove notifier" Mario Limonciello (AMD)
2026-06-04 4:54 ` Claude review: " Claude Code Review Bot
2026-05-31 11:48 ` [PATCH v5 02/11] backlight: add kernel-internal backlight API Mario Limonciello (AMD)
2026-06-04 4:54 ` Claude Code Review Bot [this message]
2026-05-31 11:49 ` [PATCH v5 03/11] drm: link connectors to backlight devices Mario Limonciello (AMD)
2026-06-04 4:54 ` Claude review: " Claude Code Review Bot
2026-05-31 11:49 ` [PATCH v5 04/11] DRM: Add support for client indicating support for luminance Mario Limonciello (AMD)
2026-06-04 4:54 ` Claude review: " Claude Code Review Bot
2026-05-31 11:49 ` [PATCH v5 05/11] drm/amd/display: Pass up errors reading actual brightness Mario Limonciello (AMD)
2026-06-04 4:54 ` Claude review: " Claude Code Review Bot
2026-05-31 11:49 ` [PATCH v5 06/11] drm/amd/display: Allow backlight registration to fail Mario Limonciello (AMD)
2026-06-04 4:54 ` Claude review: " Claude Code Review Bot
2026-05-31 11:49 ` [PATCH v5 07/11] drm/amd/display: Move backlight tracing out of the dc lock Mario Limonciello (AMD)
2026-06-04 4:54 ` Claude review: " Claude Code Review Bot
2026-05-31 11:49 ` [PATCH v5 08/11] drm/amd/display: use drm backlight Mario Limonciello (AMD)
2026-06-04 4:54 ` Claude review: " Claude Code Review Bot
2026-05-31 11:49 ` [PATCH v5 09/11] drm/amd/display: Drop brightness caching in amdgpu_dm Mario Limonciello (AMD)
2026-06-04 4:54 ` Claude review: " Claude Code Review Bot
2026-05-31 11:49 ` [PATCH v5 10/11] drm/bridge: auto-link panel backlight in bridge connector Mario Limonciello (AMD)
2026-06-04 4:54 ` Claude review: " Claude Code Review Bot
2026-05-31 11:49 ` [PATCH v5 11/11] drm/i915/display: use drm backlight Mario Limonciello (AMD)
2026-06-04 4:54 ` Claude review: " Claude Code Review Bot
2026-06-04 4:54 ` Claude review: Add support for a DRM backlight capability Claude Code Review Bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=review-patch2-20260531114908.1693426-3-superm1@kernel.org \
--to=claude-review@example.com \
--cc=dri-devel-reviews@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox