From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm/rockchip: dw_dp: Add missing newline in dev_err_probe() message
Date: Thu, 04 Jun 2026 13:55:05 +1000 [thread overview]
Message-ID: <review-patch2-20260601-drm-rk-fixes-v4-2-c3f3f123e1da@collabora.com> (raw)
In-Reply-To: <20260601-drm-rk-fixes-v4-2-c3f3f123e1da@collabora.com>
Patch Review
**Correctness: Good.** Trivial fix adding `\n` to the `dev_err_probe()` format string:
```c
- "Failed to init bridge connector");
+ "Failed to init bridge connector\n");
```
This is correct — `dev_err_probe()` uses `dev_err()` internally which does not append a newline, so the caller must provide it.
**Has two Fixes tags**, one for the original code and one for a simplification commit that touched this line. Both are reasonable.
No issues.
---
Generated by Claude Code Patch Reviewer
next prev parent reply other threads:[~2026-06-04 3:55 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-01 16:13 [PATCH v4 0/3] Rockchip DRM use-after-free & null-ptr-deref fixes Cristian Ciocaltea
2026-06-01 16:13 ` [PATCH v4 1/3] drm/bridge: synopsys: dw-dp: Support unregistering the AUX channel Cristian Ciocaltea
2026-06-04 3:55 ` Claude review: " Claude Code Review Bot
2026-06-01 16:13 ` [PATCH v4 2/3] drm/rockchip: dw_dp: Add missing newline in dev_err_probe() message Cristian Ciocaltea
2026-06-03 13:01 ` Andy Yan
2026-06-04 3:55 ` Claude Code Review Bot [this message]
2026-06-01 16:13 ` [PATCH v4 3/3] drm/rockchip: dw_dp: Release core resources Cristian Ciocaltea
2026-06-03 13:03 ` Andy Yan
2026-06-04 3:55 ` Claude review: " Claude Code Review Bot
2026-06-02 19:31 ` [PATCH v4 0/3] Rockchip DRM use-after-free & null-ptr-deref fixes Heiko Stuebner
2026-06-04 3:55 ` Claude review: " Claude Code Review Bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=review-patch2-20260601-drm-rk-fixes-v4-2-c3f3f123e1da@collabora.com \
--to=claude-review@example.com \
--cc=dri-devel-reviews@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox