From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: nouveau/gsp/rpc: Cleanup incorrect IS_ERR_OR_NULL in rpc.c Date: Thu, 04 Jun 2026 14:22:54 +1000 Message-ID: In-Reply-To: <20260601095403.228220-3-zenghongling@kylinos.cn> References: <20260601095403.228220-1-zenghongling@kylinos.cn> <20260601095403.228220-3-zenghongling@kylinos.cn> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Patch Review **Already applied on drm-next.** The changes are correct: - `r535_gsp_msgq_peek()` only returns `ERR_PTR(ret)` (rpc.c:215) or a valid= data pointer (rpc.c:219) =E2=80=94 never NULL. - `r535_gsp_msgq_recv_one_elem()` only returns `ERR_PTR(ret)` (rpc.c:246, 2= 58) or `buf` from kvmalloc which was NULL-checked earlier =E2=80=94 never N= ULL. All three call sites correctly narrowed from `IS_ERR_OR_NULL()` to `IS_ERR(= )`. --- Generated by Claude Code Patch Reviewer