From mboxrd@z Thu Jan  1 00:00:00 1970
From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm/hibmc: Fix list of formats on the primary plane
Date: Thu, 04 Jun 2026 14:13:48 +1000
Message-ID: <review-patch2-20260601114756.51953-3-tzimmermann@suse.de>
In-Reply-To: <20260601114756.51953-3-tzimmermann@suse.de>
References: <20260601114756.51953-1-tzimmermann@suse.de> <20260601114756.51953-3-tzimmermann@suse.de>
X-Mailer: Claude Code Patch Reviewer
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0

Patch Review

**Status: Good**

```c
static const u32 channel_formats1[] = {
	DRM_FORMAT_XRGB8888,
	DRM_FORMAT_RGB565,
};
```

The removals are well-justified in the commit message:

- **Alpha formats** (ARGB8888, RGBA8888, etc.): the hardware path has no transparency support, so advertising alpha channels is misleading.
- **BGR-order formats**: no channel swizzle support in the implementation.
- **RGB888**: the format register calculation `cpp[0] * 8 / 16` produces `3 * 8 / 16 = 1` (integer truncation), which programs `1` into HIBMC_CRT_DISP_CTL_FORMAT, meaning the hardware is configured for RGB565 when the buffer is actually RGB888 -- producing garbled output.

Clean fix, appropriate for stable.

---
Generated by Claude Code Patch Reviewer